Disable nested types #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two reasons for this: - To be able to get the java converter running on non-windows platforms - To lower the barrier to writing encoders that will not easily have access to these encodings in their first versions
|
I think there is an easy fix for this, so that there is no need for commenting it out. Is it ok for you when i fix it at the beginning of the next week? |
|
@mactrem great, yes, fixing early next week works. Once you have a new PR open, feel free to close this one without merging. |
|
closing, and moved this issue to a ticket: #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #29 (comment) it appears that support for nested types may not be fully working right now. So I'm proposing disabling to get the tests passing and then re-enabling in a followup PR in the future.
This depends on #31 and can wait until that one merges.