Fix NG0953 caused by event errors

[HarelM]

Fixes #193 by adding a subscription to all the events and unsubscribing when removing the relevant object.
I think this might cause some issue with the popup events, but I'm not sure which scenario is the right one and how it should behave.
In any case I think it's better than failing to present a popup.

• Popup click changing routes results in NG0953 #193

[marcjulian]

I testet the latest release 18.1.3 with this fix. In my app the error #193 is still present. I will try to provide a reproduction, that we can fix it.

[HarelM]

It might be the issue that I saw with the destroy with the marker and popup.
The main issue I solved is around layers, I think.
Can you check if you align the ngDestory stuff this issue is resolved?
Also, I think there is a situation I was able to reproduce where both "if"s in the popup destroy are false and the popup unregistering is not called, see here - (the attached marker is null, and feature and lnglat are not defined since the popup is attached to a marker):

ngx-maplibre-gl/projects/ngx-maplibre-gl/src/lib/popup/popup.component.ts

Lines 202 to 211 in 3174b8a

	removePopupFromMarker() {
	if (this.popupInstance) {
	const markerInstance = this.marker()?.markerInstance();
	if (this.lngLat() || this.feature()) {
	this.mapService.removePopupFromMap(this.popupInstance);
	} else if (markerInstance) {
	this.mapService.removePopupFromMarker(markerInstance);
	}
	}
	this.popupInstance = null;