Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Open Drone ID documentation #477

Merged
merged 11 commits into from
Sep 14, 2022
Merged

Conversation

friissoren
Copy link
Contributor

@hamishwillee @tridge @BluemarkInnovations @ThomasDebrunner @sborenstein-ift

A first attempt at updating the MAVLink documentation for drone ID. Please review and comment.

Copy link

@timtuxworth timtuxworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. I think the one about the use of the word "transmitter" is quite important.

en/services/opendroneid.md Outdated Show resolved Hide resolved
en/services/opendroneid.md Outdated Show resolved Hide resolved
en/services/opendroneid.md Outdated Show resolved Hide resolved
@friissoren
Copy link
Contributor Author

One more thing came to my mind, that should possibly be mentioned in the documentation as well.

In emergency situations there are multiple parts of the UAS that can declare emergency and there needs to be a strategy to ensure other parts of the UAS doesn't overwrite that information. I wrote some initial thoughts about that here. I would very much appreciate input on how you all think this should be solved and I sincerely hope that ArduPilot and PX4 could come up with an aligned strategy for solving this.

@friissoren
Copy link
Contributor Author

I did some updates, which I hope resolves the above comments/concerns.

I pushed these as a separate commit, to make it easier to review the changes. I trust that Hamish will squash everything when this eventually gets merged, in order to keep the history nice and clean.

@BluemarkInnovations
Copy link

I think it is a good description of Open Drone ID for MAVLink users. Personally, I would add one or two sentences in the introduction about Remote ID.

Direct Remote Identification or Remote ID (RID) is an (upcoming) mandatory technology for UAVs in Japan, US and EU. Data such as real time location, serial number. operator ID are broadcast via Wi-Fi or Bluetooth. Open Drone ID is an open source implementation of RID.

@timtuxworth
Copy link

I wouldn't say "upcoming" - this statement will be obsolete in 10 days.

@timtuxworth
Copy link

timtuxworth commented Sep 5, 2022

Overall this looks great, I think it explains everything clearly.

@BluemarkInnovations
Copy link

I wouldn't say "upcoming" - this statement will be obsolete in 10 days.

In the EU it is upcoming. (It becomes mandatory in the EU on January 1st 2024.)

@friissoren
Copy link
Contributor Author

I added an additional commit with some introductory text along the lines of what @BluemarkInnovations suggested.

Signed-off-by: Soren Friis <[email protected]>
@hamishwillee
Copy link
Collaborator

Just a few comments.

@friissoren
Copy link
Contributor Author

Just a few comments.

Just a few :-) Thanks for the very thorough review. I pushed some changes to cover most of your comments.

Signed-off-by: Soren Friis <[email protected]>
@hamishwillee
Copy link
Collaborator

Great. It looks pretty good to me, but can we get/do we need more detailed ArduPilot / PX4 review? @auturgy @ThomasDebrunner

@hamishwillee
Copy link
Collaborator

hamishwillee commented Sep 14, 2022

This looks good to me and has been reviewed by people who know the intent. I'm going to merge. @auturgy @ThomasDebrunner @tridge - if you have comments we'd appreciate them. Even though we're removing the WIP tagging on this, I think we all understand that it has to be "somewhat" WIP until the whole compliance things settles.

@hamishwillee hamishwillee merged commit 5c4a796 into mavlink:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants