-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8 Unit tests #319
K8 Unit tests #319
Conversation
Signed-off-by: Philip Obiora <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
@Revolyssup pls I will need the Pr to be reviewed, I feel I am really missing something in the code to make the test case work . @Aisuko mentioned using a controller-runtime to create a response. |
Yes, we have done this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the CI issues
Signed-off-by: Philip-21 <[email protected]>
i have checked the ci issues it has to do with the response errors i mentioned earlier, i have pinged @Revolyssup i am still waiting for his reply and suggestions |
mckpod := MockClient{ | ||
Object: "Pod", | ||
Method: "GET", | ||
RequestUrl: fmt.Sprintf("%sapi/v1/namespaces", ctx), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Philip-21 You dont need to use ctx
here as the prefix. Use the address given in test.yml
Signed-off-by: Philip-21 <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi, @Philip-21 Are you still working on it? |
Yes, i will create time and look into this |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
This PR fixes #
Notes for Reviewers
Signed commits
All unit tests for k8 packages in Meshkit
K8 unit tests for describe package continuation from pr #306 and #287