Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8 Unit tests #319

Closed
wants to merge 6 commits into from
Closed

K8 Unit tests #319

wants to merge 6 commits into from

Conversation

Philip-21
Copy link
Member

@Philip-21 Philip-21 commented May 20, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

All unit tests for k8 packages in Meshkit

K8 unit tests for describe package continuation from pr #306 and #287

@Philip-21
Copy link
Member Author

Philip-21 commented May 26, 2023

@Revolyssup pls I will need the Pr to be reviewed, I feel I am really missing something in the code to make the test case work .
As you had said earlier, i created and initialized a test.yml file to be used as my meshclient.
When running the testcase it gave this error message ,
“A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.”

@Aisuko mentioned using a controller-runtime to create a response.
I'll need your review on this to continue working with the Pr

@leecalcote leecalcote requested review from Azanul and Aisuko May 26, 2023 22:03
@leecalcote leecalcote added the area/tests Testing / quality assurance label May 26, 2023
@Aisuko
Copy link
Member

Aisuko commented May 28, 2023

@Revolyssup pls I will need the Pr to be reviewed, I feel I am really missing something in the code to make the test case work . As you had said earlier, i created and initialized a test.yml file to be used as my meshclient. When running the testcase it gave this error message , “A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.”

@Aisuko mentioned using a controller-runtime to create a response. I'll need your review on this to continue working with the Pr

Yes, we have done this in meshery-operator as you mentioned above. For meshery/mshkit. It would be better if we can get some suggestions from @Revolyssup. As I mentioned before, please get a confirmation of the solution, after that it is good to go.

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the CI issues

Signed-off-by: Philip-21 <[email protected]>
@Philip-21
Copy link
Member Author

Please check the CI issues

i have checked the ci issues it has to do with the response errors i mentioned earlier, i have pinged @Revolyssup i am still waiting for his reply and suggestions

mckpod := MockClient{
Object: "Pod",
Method: "GET",
RequestUrl: fmt.Sprintf("%sapi/v1/namespaces", ctx),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Philip-21 You dont need to use ctx here as the prefix. Use the address given in test.yml

Signed-off-by: Philip-21 <[email protected]>
@stale
Copy link

stale bot commented Sep 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 10, 2023
@Aisuko
Copy link
Member

Aisuko commented Sep 11, 2023

Hi, @Philip-21 Are you still working on it?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Sep 11, 2023
@Philip-21
Copy link
Member Author

Hi, @Philip-21 Are you still working on it?

Yes, i will create time and look into this

Copy link

stale bot commented Nov 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 5, 2023
Copy link

stale bot commented Nov 15, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Testing / quality assurance issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants