fix various pipeline failures #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like actions/runner-images#10703 took away support for xcode 14. That is why the latest action failed. There an active PR adding support for xcode 16 to the macos runner (actions/runner-images#10967). This commit will fail until that has been merged, but it is probably worth waiting for.
CI checks are failing because the cmake version requires cmake minimum requires >= 3.10. This PR addresses that issue.
Note: not using the latest version (v1.15.2) because there is a bug requiring that requires -std=c++17 to build.
This was referenced Nov 15, 2024
Closed
carsonRadtke
changed the title
carsonRadtke
force-pushed
the
fix-cmake-min-version
branch
from
71b58d1
to
373a18c
Compare
carsonRadtke
commented
Nov 25, 2024
| @@ -38,7 +38,7 @@ jobs: | |||
| echo "Emulator starting in background" | |||
| - name: Configure | |||
| run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_LATEST_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug .. | |||
There was a problem hiding this comment.
actions/runner-images claims that cmake version 3.22.1 ships with Android on macos-14, but I couldn't find it. I would prefer using the builtin one (and keep the -Werror=dev flag), but at the end of the day we control neither the image nor the cmake file so removing the dev flag is fine.
carsonRadtke
commented
Nov 25, 2024
| project(googletest-download NONE) | ||
|
|
||
| include(ExternalProject) | ||
| ExternalProject_Add(googletest | ||
| GIT_REPOSITORY https://github.com/google/googletest.git | ||
| GIT_TAG 1b18723e874b256c1e39378c6774a90701d70f7a | ||
| GIT_TAG v1.14.0 |
There was a problem hiding this comment.
This is not the latest version, but v1.15 is incompatible with -std=c++14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI checks are failing because the cmake version requires cmake minimum requires >= 3.10. This PR addresses that issue.
Looks like actions/runner-images#10703 took away support for xcode 14. That is why the latest action failed. There an active PR adding support for xcode 16 to the macos runner (actions/runner-images#10967). This commit will fail until that has been merged, but it is probably worth waiting for. Edit: Looks like that PR was closed, so we won't wait.