-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuxsy-AutodeskFusionManage (Independent Publisher) #3647
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree [company="{Fuxsy s.r.o.}"] |
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rmnkvrk,
Swagger files tool large not able to open here to add the comment at line level. However, adding comments below. Please fix the same.
- posibilities - please correct this spelling
- permision id si get permissons - please correct this sentence
- Dupdate - Please correct this spelling
- paremeter - Please correct the spelling
- Deatils - Please correct the spelling
- loged - Please correct the spelling
There are 289 swagger validation errors, please check them and fix them.
Please refer the readme.file in this url and fix the errors - https://github.com/microsoft/PowerPlatformConnectors
Hi @vmanoharas Thank you. |
Changes based on errors feedback from publish process to MS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rmnkvrk,
Please refer the below swagger validation errors and resolve them. Please refer below links for the help.
Swagger Template - https://github.com/microsoft/PowerPlatformConnectors/blob/dev/templates/Independent%20Publisher/apiDefinition.swagger.json
Swagger Schema - https://github.com/microsoft/PowerPlatformConnectors/blob/dev/schemas/apiDefinition.swagger.schema.json
IP Connector documentation - https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip
##[error]The 'description' property is required. ValuePath: /info
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups/get/parameters/01groups/get/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups/get/parameters/11groups/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups/get/parameters/21groups/get/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups1{GroupID}/get/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1api1v31groups1{GroupID}/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups1{GroupID}1users/get/parameters/01groups
##[error]The 'description' property is required. ValuePath: /paths/1api1v31{GroupID}1{GroupID}1users/get/parameters/01groups
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31users/get/parameters/11groups~1{GroupID}~1users/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
independent-publisher-connectors/Fuxsy-AutodeskFusionManage/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
Fixed issue base don validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rmnkvrk,
Not able to comment on the particular line, kindly resolve below issues, before proceeding further review.
correct the typo retrive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rmnkvrk,
Unfortunately, I cannot open your swagger.json file to comment each and every line to provide my comment, there are 281 places where you have empty strings ("") for descriptions, urls, params, please correct them and resubmit you connector by following the below templates and schemas.
independent-publisher-connectors/Fuxsy-AutodeskFusionManage/readme.md
Outdated
Show resolved
Hide resolved
Update readme based on recomended template
Fixed responses erros & most of warnings from validation
Hi @vmanoharas we just uploaded updated version of swager. Thanks for your reply and help. |
Fixed transition response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comments has been proceeded in new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rmnkvrk,
Could you please resolve review comment?
independent-publisher-connectors/Fuxsy-AutodeskFusionManage/readme.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Partner
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.
[[certify-connector]] |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: