Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuxsy-AutodeskFusionManage (Independent Publisher) #3647

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

rmnkvrk
Copy link

@rmnkvrk rmnkvrk commented Sep 11, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@rmnkvrk rmnkvrk requested a review from a team as a code owner September 11, 2024 09:21
@rmnkvrk
Copy link
Author

rmnkvrk commented Sep 11, 2024

@microsoft-github-policy-service agree [company="{Fuxsy s.r.o.}"]

@rmnkvrk
Copy link
Author

rmnkvrk commented Sep 11, 2024

@microsoft-github-policy-service agree

@rmnkvrk
Copy link
Author

rmnkvrk commented Sep 11, 2024

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rmnkvrk,

Swagger files tool large not able to open here to add the comment at line level. However, adding comments below. Please fix the same.

  1. posibilities - please correct this spelling
  2. permision id si get permissons - please correct this sentence
  3. Dupdate - Please correct this spelling
  4. paremeter - Please correct the spelling
  5. Deatils - Please correct the spelling
  6. loged - Please correct the spelling

There are 289 swagger validation errors, please check them and fix them.

Please refer the readme.file in this url and fix the errors - https://github.com/microsoft/PowerPlatformConnectors

@rmnkvrk
Copy link
Author

rmnkvrk commented Sep 25, 2024

Hello @rmnkvrk,

Swagger files tool large not able to open here to add the comment at line level. However, adding comments below. Please fix the same.

  1. posibilities - please correct this spelling
  2. permision id si get permissons - please correct this sentence
  3. Dupdate - Please correct this spelling
  4. paremeter - Please correct the spelling
  5. Deatils - Please correct the spelling
  6. loged - Please correct the spelling

There are 289 swagger validation errors, please check them and fix them.

Please refer the readme.file in this url and fix the errors - https://github.com/microsoft/PowerPlatformConnectors

Hi @vmanoharas
We just fixed your described errors thanks for that.
But, we dont have access or are not able to see all errors over your validation. Is there a way to get that error report that we can work on that for fix?

Thank you.

Changes based on errors feedback from publish process to MS
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rmnkvrk,

Please refer the below swagger validation errors and resolve them. Please refer below links for the help.

Swagger Template - https://github.com/microsoft/PowerPlatformConnectors/blob/dev/templates/Independent%20Publisher/apiDefinition.swagger.json

Swagger Schema - https://github.com/microsoft/PowerPlatformConnectors/blob/dev/schemas/apiDefinition.swagger.schema.json

IP Connector documentation - https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip

##[error]The 'description' property is required. ValuePath: /info
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups/get/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
1groups/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
1groups/get/parameters/1
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups/get/parameters/2
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
1groups/get/parameters/2
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups1{GroupID}/get/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1api1v31groups1{GroupID}/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v31groups1{GroupID}1users/get/parameters/0
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
1groups1{GroupID}1users/get/parameters/0
##[error]The 'x-ms-summary' property is required. ValuePath: /paths/1api1v3
1groups
1{GroupID}1users/get/parameters/1
##[error]The 'description' property is required. ValuePath: /paths/1api1v3
1groups~1{GroupID}~1users/get/parameters/1

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rmnkvrk,

Not able to comment on the particular line, kindly resolve below issues, before proceeding further review.

correct the typo retrive

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rmnkvrk,

Unfortunately, I cannot open your swagger.json file to comment each and every line to provide my comment, there are 281 places where you have empty strings ("") for descriptions, urls, params, please correct them and resubmit you connector by following the below templates and schemas.

https://github.com/microsoft/PowerPlatformConnectors/tree/1bc6f95d8c66e41d234bcf4627cdd53bee1d0ac4/templates/Independent%20Publisher

https://github.com/microsoft/PowerPlatformConnectors/tree/1bc6f95d8c66e41d234bcf4627cdd53bee1d0ac4/schemas

Update readme based on recomended template
Fixed responses erros & most of warnings from validation
@rmnkvrk
Copy link
Author

rmnkvrk commented Oct 23, 2024

Hi @vmanoharas we just uploaded updated version of swager.
All of Empty strigs has ben fixed and we also fixed most of warning from validation.
Still some warnings are there anyway I belive that will not be problem and also we are going to fixed them later of.

Thanks for your reply and help.

Fixed transition response
Copy link
Author

@rmnkvrk rmnkvrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your comments has been proceeded in new version

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rmnkvrk,

Could you please resolve review comment?

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Partner

I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

[[certify-connector]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants