-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ironclad CLM (Independent Publisher) #3709
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @maxhenkentech,
Please address the review comments and remove the intro.md file which is not needed for Independent Publisher connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @maxhenkentech,
Please resolve review comments.
independent-publisher-connectors/Ironclad CLM/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiProperties.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiProperties.json
Outdated
Show resolved
Hide resolved
fixed typos
typos fixed
Thank you, @vmanoharas! All done. |
Added support for Workflow Documents as Array as requested by Ironcald
Added support for Workflow Documents as Array as requested by Ironclad
@vmanoharas: Made minor changes to add support for a feature requested by Ironclad |
Hello @maxhenkentech, Thank you! Could you please update the files with proper indentation? please check the below documentation. https://learn.microsoft.com/en-us/connectors/custom-connectors/coding-standards#api-definition |
Hi @vmanoharas - I pushed all json and C# files through a code prettifier. Hope this works for you guys. Let me know if anything else is required |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:
3 Unique Actions:
All Action:
Test Page: