Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ironclad CLM (Independent Publisher) #3709

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

maxhenkentech
Copy link

@maxhenkentech maxhenkentech commented Nov 12, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • [N/A] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

3 Unique Actions:

image

image

image

All Action:

image

Test Page:

image

@maxhenkentech maxhenkentech requested a review from a team as a code owner November 12, 2024 12:06
@maxhenkentech
Copy link
Author

@microsoft-github-policy-service agree

@maxhenkentech maxhenkentech changed the title Ironclad CLM Independent Publisher Ironclad CLM (Independent Publisher) Nov 12, 2024
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @maxhenkentech,

Please address the review comments and remove the intro.md file which is not needed for Independent Publisher connector.

image

independent-publisher-connectors/Ironclad CLM/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @maxhenkentech,

Please resolve review comments.

@maxhenkentech
Copy link
Author

maxhenkentech commented Nov 19, 2024

Hello @maxhenkentech,

Please resolve review comments.

Thank you, @vmanoharas! All done.

Added support for Workflow Documents as Array as requested by Ironcald
Added support for Workflow Documents as Array as requested by Ironclad
@maxhenkentech
Copy link
Author

@vmanoharas: Made minor changes to add support for a feature requested by Ironclad

@vmanoharas
Copy link
Contributor

Hello @maxhenkentech,

Thank you!

Could you please update the files with proper indentation? please check the below documentation.

https://learn.microsoft.com/en-us/connectors/custom-connectors/coding-standards#api-definition

@maxhenkentech
Copy link
Author

Hi @vmanoharas - I pushed all json and C# files through a code prettifier. Hope this works for you guys. Let me know if anything else is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants