Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IconsDataSchema #1634

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add IconsDataSchema #1634

wants to merge 3 commits into from

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Oct 13, 2024

Description

Same as #1630

Motivation and Context

How Has This Been Tested?

Manual

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

marcelwgn
marcelwgn approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again love the idea, thank you for making this contribution!

karkarl
karkarl approved these changes Nov 13, 2024
View reviewed changes
WinUIGallery/WinUIGallery.csproj Outdated Show resolved Hide resolved
@karkarl
Copy link
Collaborator

karkarl commented Nov 13, 2024

Please rebase from main to resolve this conflict. Thanks again for opening this PR, excited to get this in!

@HO-COOH
Copy link
Contributor Author

HO-COOH commented Nov 17, 2024

Please rebase from main to resolve this conflict. Thanks again for opening this PR, excited to get this in!

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn approved these changes

@karkarl karkarl karkarl approved these changes

Assignees
No one assigned
Labels
needs-author-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HO-COOH @karkarl @marcelwgn