Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Color page sample code #1653

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AndrewKeepCoding
Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding commented Nov 14, 2024

Description

Added sample code for the theme resource brush use.

Motivation and Context

How Has This Been Tested?

Ran the app and confirme the change.

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@niels9001
Copy link
Contributor

Could we do just the XAML string as a code block and not the Expander? The core functionality of this tool is to quickly look up brushes, having the expander here would introduce additional scrolling and pushes down the most important info.. thoughts?

@AndrewKeepCoding
Copy link
Contributor Author

Something like this?

image

@niels9001
Copy link
Contributor

Nit: can we shorten the 'Text="..."' and keep everything on a single line?

@AndrewKeepCoding
Copy link
Contributor Author

Nit: can we shorten the 'Text="..."' and keep everything on a single line?

Pushed the changes.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants