Refactor SampleCodePresenter
to adjust code presenter visibility handling
#1666
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
SampleCodePresenter
to improve code presenter visibility handling and align its behavior with broader application usage patterns, the only change is:SampleCodePresenter_Loaded
method inSampleCodePresenter.xaml.cs
to enhance visibility handling forCodePresenter
by removing logic to collapse code presenter visibility by default.Motivation and Context
CodePresenter
in scenarios where it was not explicitly needed. This conflicted with scenarios like theIconography Page
, where an emptyCodePresenter
is defined and modified dynamically later.ControlExample.HandlePresenterVisibility
method, making redundant visibility management unnecessary withinSampleCodePresenter
in most cases.CodePresenter
, its visibility is now set to Visible by default, and changes are applied only when truly needed.How Has This Been Tested?
Manual Testing:
HandlePresenterVisibility()
manages visibility logic.Screenshots:
- Before: Code presenters collapsed unnecessarily where they defined empty to be modified dynamically later.
- After: Proper handling of empty code presenters and visibility.
Types of changes