fix(fabric, a11y): implement accessibility role #2293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 21, 2024 14:40
Summary:
Paper was rendering text as AXStaticText. This diff updates the `RCTParagraphComponentView` to propagate the same role in Fabric for text.
This change will allow to select UI elements based on the text contents.
Test Plan:
Use the Accessibility Inspector in Zeratul with Fabric enabled. With the changes the text elements are presented in the a11y hierarchy with AXStaticText:
{F1162808272}
Reviewers: shawndempsey, chpurrer, #rn-desktop
Reviewed By: chpurrer
Differential Revision: https://phabricator.intern.facebook.com/D51736932
Tasks: T170938725
Tags: uikit-diff
Summary:
Paper was rendering text as AXStaticText. This diff updates the `RCTParagraphComponentView` to propagate the same role in Fabric for text.
This change will allow to select UI elements based on the text contents.
Test Plan:
Use the Accessibility Inspector in Zeratul with Fabric enabled. With the changes the text elements are presented in the a11y hierarchy with AXStaticText:
{F1162808272}
Reviewers: shawndempsey, chpurrer, #rn-desktop
Reviewed By: chpurrer
Differential Revision: https://phabricator.intern.facebook.com/D51736931
Tasks: T170938725
Summary:
Paper was rendering text as AXStaticText. This diff updates the `RCTParagraphComponentView` to propagate the same role in Fabric for text.
This change will allow to select UI elements based on the text contents.
Test Plan:
Use the Accessibility Inspector in Zeratul with Fabric enabled. With the changes the text elements are presented in the a11y hierarchy with AXStaticText:
{F1162808272}
Reviewers: shawndempsey, chpurrer, #rn-desktop
Reviewed By: chpurrer
Differential Revision: https://phabricator.intern.facebook.com/D51736933
Tasks: T170938725
Saadnajmi
force-pushed
the
fabric/a11y-role
branch
from
0a67bd3
to
3517bb1
Compare
Saadnajmi
commented
Nov 21, 2024
| @property (nonatomic, strong, nullable, readonly) NSObject *accessibilityElement; | ||
| @property (nonatomic, strong, nullable, readonly) RCTPlatformView *accessibilityElement; // [macOS] |
There was a problem hiding this comment.
We should probably ifdef this for iOS vs macOS
Saadnajmi
commented
Nov 21, 2024
| @@ -17,6 +17,7 @@ | |||
| #import <React/RCTConversions.h> | |||
| #import <React/RCTCursor.h> // [macOS] | |||
| #import <React/RCTLocalizedString.h> | |||
| #import <React/UIView+React.h> // [macOS] | |||
There was a problem hiding this comment.
Do we need this import?
Saadnajmi
commented
Nov 21, 2024
Comment on lines
+128
to
+130
| inline NSAccessibilityRole RCTUIAccessibilityRoleFromAccessibilityTraits( | ||
| facebook::react::AccessibilityTraits accessibilityTraits) | ||
| { |
There was a problem hiding this comment.
Double check this list with paper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs where we are cherry-picking fixes from #2117 to update our Fabric implementation on macOS.
TODO
Summary:
Pick a few changes related to implementing accessibility role
Test Plan:
CI should pass.