Views with keyUpEvents/keyDownEvents set on them should form a stacking context #14090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dify the native handling of the events
rozele
reviewed
Nov 7, 2024
| // onFocus/onBlur are often just used for listening to bubbled events. | ||
| // Only Views which are marked as focusable can actually trigger the events, which will already avoid being collapsed. | ||
| constexpr decltype(WindowsViewEvents::bits) focusEventsMask = { | ||
| (1 << (int)WindowsViewEvents::Offset::Focus) & (1 << (int)WindowsViewEvents::Offset::Blur)}; |
There was a problem hiding this comment.
Funny enough, this never did anything anyway, since you wanted | here instead of & :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, events that bubble on the JS side do not require a stacking context. But in the case of keyUpEvents/keyDownEvents, those affect the event bubbling on the native side, and so they require a stacking context.
Also modifying the setting of onKeyUp/onKeyDown on view to only be set if the view has keyUpEvents/keyDownEvents or onKeyUp/onKeyDown are set on it, as they will never do anyway if they are both undefined.
Microsoft Reviewers: Open in CodeFlow