Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove interface label for interface_stats #1067

Open
huntergregory opened this issue Nov 25, 2024 · 1 comment
Open

remove interface label for interface_stats #1067

huntergregory opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels
area/controllers area/data-ingestion-and-visualization area/plugins good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/0 P0 scope/S Change is Small type/fix Fixes something
Milestone

Comments

@huntergregory
Copy link
Contributor

huntergregory commented Nov 25, 2024

To reduce metric cardinality, we should aggregate interfaces for interface_stats. We filter out several interfaces, and only error/drop stats are included, which are unlikely, but technically, there is risk that the number of interface names could increase over time.

Before:

interface_stats{interface=eth0, stat=...}

After:

interface_stats{stat=...}
@anubhabMajumdar
Copy link
Contributor

Since this metric has been out for sometime, should we keep the interface label and set that to a constant value like allInterfaces ? Otherwise we may break existing tooling that interfaces with this metric (like Grafana dashboards).

@anubhabMajumdar anubhabMajumdar added good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language type/fix Fixes something area/plugins priority/0 P0 scope/S Change is Small labels Nov 26, 2024
@anubhabMajumdar anubhabMajumdar added this to the 1.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controllers area/data-ingestion-and-visualization area/plugins good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/0 P0 scope/S Change is Small type/fix Fixes something
Projects
Status: No status
Development

No branches or pull requests

4 participants