Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric): Update dynamic interface label to be constant #1078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BeegiiK
Copy link
Contributor

@BeegiiK BeegiiK commented Nov 26, 2024

Description

Updated dynamic interface label for interface_stats metric to be set to all_interfaces. Also did some optimisation on the EthtoolStats struct. All stat names will be accumulated across all interface names

Related Issue

#1067

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@BeegiiK BeegiiK requested a review from a team as a code owner November 26, 2024 14:27
@BeegiiK BeegiiK requested review from jimassa and rbtr November 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants