feat(ct-metrics): add initial conntrack metrics for Prometheus #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRodi
force-pushed
the
feat/conntrack-metrics
branch
from
35fee01
to
c9b9e30
Compare
|
Did we think though around scalability, performance and stability when adding these metrics? Do we have any concerns? Do we have numbers to back this up? |
SRodi
force-pushed
the
feat/conntrack-metrics
branch
from
c9b9e30
to
7aa9dbf
Compare
vakalapa
reviewed
Nov 25, 2024
| @@ -140,6 +140,26 @@ func InitializeMetrics() { | |||
| dnsResponseCounterDescription, | |||
| ) | |||
|
|
|||
| // Conntrack Metrics | |||
| ConntrackPacketsCounter = exporter.CreatePrometheusGaugeVecForMetric( | |||
There was a problem hiding this comment.
Can you find a way to integrate these into Hubble metrics as well ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create initial metrics for conntrack:
Related Issue
#806
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
This example shows a long-lived TCP connection between client
src_ip="10.244.0..230and server10.244.1.85This example shows the
bytes_count_per_connectionwheredst_ip=10.244.0.113which is the pod IP formetrics-serveron one of the cluster nodes.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.