Fix infinite recursion in TSF #18248
Merged
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
DHowett
reviewed
Nov 25, 2024
| // This can then in infinite recursion because we're calling | ||
| // GetWnd() below, which may call GetHwnd(), which may call | ||
| // FindWindowOfActiveTSF(), and so on. | ||
| // By temporarily clearing the _provider we fix that flaw. |
There was a problem hiding this comment.
Where is the determination to bail out made based on _provider?
There was a problem hiding this comment.
Throughout the file. All places that use _provider are already doing a null check.
DHowett
approved these changes
Nov 25, 2024
carlos-zamora
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
FindWindowOfActiveTSFimplementation canresult in infinite recursion which we must guard again.
This change is not tested as I don't know how to trigger
the issue to begin with (a missing CoreInput thread).