log slowest query times #210
Conversation
|
I generalized this to all requests, will log the count of queries and time of queries if you include a query param |
|
This is moving towards something we could consider putting into production. It only enables the DB profiler if a There is an additional query param that reduces the logging output. So if |
| Zend_Registry::get('logger')->info('Profiler for '.$_SERVER['REQUEST_URI']); | ||
| $db = Zend_Db_Table::getDefaultAdapter(); | ||
| $profiler = $db->getProfiler(); | ||
| $profile = ''; |
mgrauer
changed the title
|
Do you think this adds something worth getting in? If so I can clean up the history and get it ready to merge. If not, I'll kill it and delete the branch so we don't have it hanging around. IMO, it is doesn't add much overhead and can enable a useful debugging tool, so I favor putting it in. My feelings won't be hurt if you think otherwise. |
|
@mgrauer Thanks for the ping on this. I think as long as it doesn't seem like an avenue for Denial of Service or for discovery of system information (I don't think it does), then LGTM. Thanks! |
|
I don't think it is an avenue for DOS either, it just might make DOS a slight bit easier, but you would have to already be trying to do a DOS. I'll wait for @jamiesnape to weigh in since there are security implications possible. |
|
Not sure about this, to be honest. Let me think about it and get back to you. |
@cpatrick