Skip to content
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.

Unhide Zend_Exception in UtilityComponent::run_sql_from_file #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbenoist
Copy link
Contributor

@bbenoist bbenoist commented May 2, 2016

With this PR, error messages are way clearer than current Unable to connect:

capture

FYI, the error displayed here is because the MySQL instance I used had NO_ZERO_DATE enabled...

@jamiesnape
Copy link
Contributor

Is your example in development or production mode? In production, it should not give this information.

@bbenoist
Copy link
Contributor Author

bbenoist commented May 3, 2016

@jamiesnape Development mode as I am still struggling with making Midas to connect to an instance of the official MySQL Docker image.

I agree that such information might be sensible for production.

However:

  • this specific function is called for administration-only operations (AFAIK).
  • only displaying Unable to connect is not enough to determine the actual cause of an issue.

@mgrauer
Copy link
Contributor

mgrauer commented May 3, 2016

I agree it would be good to see the actual exception, but I don't think we want to display this in the web app.

How about you log the exception like this and continue to pass the existing message?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants