Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Trusty engine from Trusty SDK structs. #5011

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Decouple Trusty engine from Trusty SDK structs. #5011

merged 1 commit into from
Nov 20, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Nov 20, 2024

Summary

This change aims to limit the impact of changes deriving from Trusty SDK to fewer lines of code. Specifically, business logic implemented in Trusty evaluation engine looks into the response as returned by the SDK itself, making it harder to move to Trusty API v2.

Note: this change is meant to be bug-compatible with the current Trusty evaluation engine.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual testing and unit testing.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Nov 20, 2024
@blkt blkt force-pushed the chore/refactor-trusty-eval-engine branch from fd4bd48 to d220764 Compare November 20, 2024 12:39
@blkt
Decouple Trusty engine from Trusty SDK structs.
f23a861 
This change aims to limit the impact of changes deriving from Trusty
SDK to fewer lines of code. Specifically, business logic implemented
in Trusty evaluation engine looks into the response as returned by the
SDK itself, making it harder to move to Trusty API v2.

Note: this change is meant to be bug-compatible with the current
Trusty evaluation engine.
@blkt blkt force-pushed the chore/refactor-trusty-eval-engine branch from d220764 to f23a861 Compare November 20, 2024 12:43
@blkt blkt marked this pull request as ready for review November 20, 2024 12:58
@blkt blkt requested a review from a team as a code owner November 20, 2024 12:58
eleftherias
eleftherias approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as it did before.
Note that the existing bugs #4944 and #4945 are still present, but unrelated to this PR.

@blkt
Copy link
Contributor Author

blkt commented Nov 20, 2024

Tested locally and it works as it did before. Note that the existing bugs #4944 and #4945 are still present, but unrelated to this PR.

❤️ Thank you so much for looking into this thoroughly! 🙏

@blkt blkt merged commit 657bf01 into main Nov 20, 2024
25 checks passed
@blkt blkt deleted the chore/refactor-trusty-eval-engine branch November 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias approved these changes

Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blkt @eleftherias