Bye bye std::string in the GL library #499
Commits on Jan 1, 2023
-
-
GL: deduplicate & simplify DebugOutput::setCallback() internals.
The previous callback pointer was needed just to disambiguate, so it can be a bool; the user pointer can be set from the caller already instead of being done in each variant again.
-
Those are reserved for temporary TODOs and debugging, not meant to stay there forever.
-
-
GL: properly test failed AbstractShaderProgram::validate().
So far everything everywhere was just testing the success case, without checking that the message is properly retrieved and returned. Sigh.
-
GL: trim whitespace from AbstractShaderProgram::validate().
The test added in previous commit passed on Mesa, but not on SwiftShader.
-
-
GL: port Debug{Output,Group,Message} away from std::string.
Most of these are just inputs, so a compatibility StringStl.h include will do, the only exception is the callback for which there needs to stay a deprecated overload (which is internally delegated from the StringView one). Also explicitly testing with non-null-terminated strings -- the APIs take an explicit size so it shouldn't be a problem, but it's always good to have this verified independently. Drivers are crap, you know. One consequence of no longer using an impossible-to-forward-declare std::string is that I had to deinline the DebugGroup constructor because it no longer worked with just a forward-declared StringView.
-
Shaders: ditch the insane Phong light initializer setup.
Do it the same as for the skinning stuff, format() and string multiplication. No need to get this crazy.
-
GL: port Shader and ShaderProgram away from std::string.
Same as in the previous commit, most cases are inputs so a StringStl.h compatibility include will do, the only breaking change is GL::Shader::sources() which now returns a StringIterable instead of a std::vector<std::string> (ew). Awesome about this whole thing is that The Shader API now allows creating a shader from sources coming either from string view literals or Utility::Resource completely without having to allocate any strings internally, because all those can be just non-owning references wrapped with String::nullTerminatedGlobalView(). The only parts which aren't references are the #line markers, but (especially on 64bit) those can easily fit into the 22-byte (or 10-byte on 32bit) SSO storage. Also, various Shader constructors and assignment operators had to be deinlined in order to avoid having to include the String header, which would be needed for Array destruction during a move. Co-authored-by: Hugo Amiard <[email protected]>
-
-
-
GL: drop std::pair from AbstractShaderProgram::validate() as well.
Given that I made a breaking change by returning Containers::String instead of a std::string, I can take it further and replace also std::pair with Containers::Pair -- it won't bring any more pain to the users, they have to change their code anyway. Co-authored-by: Hugo Amiard <[email protected]>
-
GL: drop std::pair from texture state tracker internals.
Apparently even `= {}` was broken for std::pair once, not to mention the unnecessary extra overhead with this type not being trivially copyable. Good riddance. -
GL: drop another std::pair occurence from the internals.
Hm, and here I used the "capability" of std::pair that allowed it to store references. I don't even want to know what all was involved to support that, Containers::Reference is much easier to reason about.
-
GL: don't use std::pair in Context internals.
And this, this change allows the growable Array to use malloc() instead of new, and thus also realloc(), saving unnecessary reallocations if the memory can be grown in-place. All because Containers::Pair is trivially copyable while std::pair wasn't. There isn't any good reason to use the STL anymore.
-
DebugTools: port screenshot() away from std::string.
Simple & easy, for a change.
-
DebugTools: port FrameProfiler away from std::string.
One of the last remaining leftovers.
-
-
-
Remove random unneeded <string> and StringStl.h includes.
Or document why is it still needed.
-
doc: remove std::string usage from doc image generators.
From some, at least. The easings need to wait for a growable String.
-
DebugTools,Shaders,TextureTools: use string view literals everywhere.
Mainly important for Shader::addSource() to prevent it from creating a needless copy, but doesn't hurt to do the same also for uniformLocation(), bindAttributeLocation() etc. -- it'll avoid a runtime strlen() in that case at least.
-
package/archlinux: include also RelWithDebInfo in the dev PKGBUILD.
Not built by default, but handy for profiling.
