Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3378 - Data broker manual removal #5287

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

MNTOR-3378 - Data broker manual removal #5287

wants to merge 57 commits into from

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Nov 4, 2024

References:

Jira: MNTOR-3378
Figma: https://www.figma.com/design/DTbmXzCQCw2PxXpHQW8yfW/Monitor-MVP-Enhancements?node-id=3809-6501&t=EniBV7WqvPVnuivk-4

Path: /user/dashboard/fix/data-broker-profiles/removal-under-maintenance

Description

Screenshot (if applicable)

image image image

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Copy link

github-actions bot commented Nov 4, 2024

Comment on lines +11 to +12
| "removed"
| "removal_under_maintenance";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhelmer I believe this would be our first time consuming this endpoint for the manual data broker removal feature.

@codemist codemist requested a review from rhelmer November 4, 2024 19:20
Copy link

github-actions bot commented Nov 4, 2024

Copy link

github-actions bot commented Nov 4, 2024

Copy link

github-actions bot commented Nov 6, 2024

@codemist codemist marked this pull request as ready for review November 12, 2024 18:53
@codemist codemist added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Nov 12, 2024
Copy link

MNTOR-3815: call for scan results with broker under maintenance
Copy link

Comment on lines 44 to 48
const getNextStep = getNextGuidedStep(data, "DataBrokerManualRemoval");

if (scansWithRemovalUnderMaintenance === null) {
redirect(getNextStep.href);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flozia I was trying to understand this getNextGuidedStep function more, but it seems that the second argument is optional and it would work with just passing in that StepDeterminationData type, but when I returned the value it would give me the current step id, not the next one, so the name of the function may be misleading? Unless I'm understanding it incorrectly.

@codemist
Copy link
Collaborator Author

Fixed that linter error here 32831a1 @flozia

Comment on lines +122 to +127
switch (scanResult.status) {
case "removal_under_maintenance":
return l10n.getFragment(
"exposure-card-description-info-for-sale-fixed-removal-under-maintenance-manually-fixed",
{ elems: { data_broker_profile: dataBrokerProfileLink } },
);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 Do Not Merge Do not merge this PR, even if approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants