-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNTOR-3378 - Data broker manual removal #5287
base: main
Are you sure you want to change the base?
Conversation
Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app |
| "removed" | ||
| "removal_under_maintenance"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhelmer I believe this would be our first time consuming this endpoint for the manual data broker removal feature.
Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app |
Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app |
Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app |
Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app |
MNTOR-3815: call for scan results with broker under maintenance
Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app |
* fix: fix comment vars * pass SENTRY_AUTH_TOKEN arg to docker (#5324) * integration * rebase * bad rebase fix * bad rebase fix --------- Co-authored-by: Joey Zhou <[email protected]> Co-authored-by: Robert Helmer <[email protected]>
const getNextStep = getNextGuidedStep(data, "DataBrokerManualRemoval"); | ||
|
||
if (scansWithRemovalUnderMaintenance === null) { | ||
redirect(getNextStep.href); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flozia I was trying to understand this getNextGuidedStep
function more, but it seems that the second argument is optional and it would work with just passing in that StepDeterminationData
type, but when I returned the value it would give me the current step id, not the next one, so the name of the function may be misleading? Unless I'm understanding it incorrectly.
switch (scanResult.status) { | ||
case "removal_under_maintenance": | ||
return l10n.getFragment( | ||
"exposure-card-description-info-for-sale-fixed-removal-under-maintenance-manually-fixed", | ||
{ elems: { data_broker_profile: dataBrokerProfileLink } }, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
References:
Jira: MNTOR-3378
Figma: https://www.figma.com/design/DTbmXzCQCw2PxXpHQW8yfW/Monitor-MVP-Enhancements?node-id=3809-6501&t=EniBV7WqvPVnuivk-4
Path: /user/dashboard/fix/data-broker-profiles/removal-under-maintenance
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)