ci: add plotly to downstream tests #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
nice one!
regarding performance, we could also manually check:
- latest plotly version with latest narwhals version
- latest plotly version with latest narwhals commit
and check there's no significant difference. once we sort out automated performance benchmarks we do it as part of that
|
@FBruzzesi shall we ship this? |
|
Sure let's merge this as is for now and adjust later if plotly comes back with another plan for test suite we should care about 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
If you have comments or can explain your changes, please do so below.
Since yesterday the PR to narwhalify plotly express got merged, we should start to include (some) plotly tests in our ci as promised!
Opening this as draft because it was not fully decided which tests should be run.
@emilykl this is along the lines of how we would test that each commit does not end up breaking plotly via its unit tests
Associated plotly issue: plotly/plotly.py#4864