feat: use async trait #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
use-async-trait
branch
3 times, most recently
from
56c49b8
to
ef647d0
Compare
TheWaWaR
reviewed
May 17, 2021
TheWaWaR
reviewed
May 17, 2021
| @@ -536,25 +420,33 @@ where | |||
| // Send data to the specified protocol for the specified session. | |||
| TargetSession::Single(id) => { | |||
| if let Some(control) = self.sessions.get_mut(&id) { | |||
| control.push_message(proto_id, priority, data); | |||
| control.try_send(cx); | |||
| control.inner.incr_pending_data_size(data.len()); | |||
There was a problem hiding this comment.
Better incr_pending_data_size() inside control.send() (by destruct SessionEvent::ProtocolMessage) in case we don't forget it before send ProtocolMessage.
There was a problem hiding this comment.
incr_pending_data_size only exists in this function, there is no need for the operation of this function to cause all other commands to also carry the destruct operation
TheWaWaR
approved these changes
May 17, 2021
doitian
approved these changes
Jul 24, 2021
doitian
approved these changes
Jul 24, 2021
There was a problem hiding this comment.
Reviewed 37 of 37 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @driftluo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #305
This PR achieves a complete migration to the async trait, users can write code in async env
tentacle/src/traits.rsis the core of the modificationtentacle/src/channel/bound.rsChannels adds two async methods that do not use mut to facilitate the uniformity of the user interface and avoid unnecessary mut markstentacle/src/protocol_handle_stream.rsandtentacle/src/service.rsas the place to inherit the implementation of the user’s async trait, part of the logic is inevitably rewrittenOther changes are due to the changes caused by the above changes
This change is