Test that BCL Types work with NodaTime plugin activated #1532
Conversation
…ed to verify that all BCL date/time types are properly supported. Closes npgsql#1490
|
Edit: I guess this is because my local Postgres db might use a different culture. Can this be enforced in the test-suite (e.x. by setting the culture when scaffolding the test db)? |
davidroth
changed the title
davidroth
changed the title
| <PropertyGroup> | ||
| <EFCoreVersion>5.0.0-rc.1.20451.13</EFCoreVersion> | ||
| <MicrosoftExtensionsVersion>5.0.0-rc.1.20451.14</MicrosoftExtensionsVersion> | ||
| <NpgsqlVersion>5.0.0-ci.20201003T171056</NpgsqlVersion> | ||
| <NpgsqlVersion>5.0.0-ci.20201017T090100</NpgsqlVersion> |
There was a problem hiding this comment.
Needed to update to pull these changes in.
| : base(fixture) | ||
| { | ||
| Fixture.TestSqlLoggerFactory.Clear(); | ||
| //Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper); |
There was a problem hiding this comment.
Comment copied over from line 28 in main branch. Should I remove it?
|
@davidroth sorry I haven't been more reactive with all this work, am busy with other stuff... Promise to come back to this in a couple days and push it through for 5.0. |
|
@davidroth am under pretty massive workload at the moment, with the 5.0 release coming up. Is there anything that isn't purely-test related, i.e. are we sure that the actual support works? If this is just about adding tests, we can always do that after 5.0 is released. |
@roji This MR is only for adding tests. The tests revealed a bug first, which has already been fixed. Beside from that, I am confident, that the current support works as expected. |
|
Thanks @davidroth, I'll look into this once things quiet down a bit. |
Run BuiltInDataTypesNpgsqlTest again with the NodaTime plugin activated to verify that all BCL date/time types are properly supported.
Closes #1490