Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auto tagging after release pr is merged #3135

Merged
merged 17 commits into from
Dec 1, 2023

Conversation

JaydipGabani
Copy link
Contributor

@JaydipGabani JaydipGabani commented Oct 31, 2023

What this PR does / why we need it: Eliminate the need for manually pushing tag to kick off release

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3037

Special notes for your reviewer:
Here is the workflow running on test fork
Here is the tag created as a result of the workflow

@JaydipGabani JaydipGabani requested a review from a team as a code owner October 31, 2023 04:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2370c50) 53.81% compared to head (1ef82ab) 53.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
- Coverage   53.81%   53.72%   -0.10%     
==========================================
  Files         136      136              
  Lines       12198    12198              
==========================================
- Hits         6564     6553      -11     
- Misses       5134     5142       +8     
- Partials      500      503       +3     
Flag Coverage Δ
unittests 53.72% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaydipGabani
Copy link
Contributor Author

@maxsmythe Found a way to gate logic without comparing commit message. PTAL

@maxsmythe
Copy link
Contributor

Nice! Who has permissions to create PR labels?

@JaydipGabani
Copy link
Contributor Author

@maxsmythe anyone with write access to gatekeeper repo can edit labels and anyone with triage access can apply labels.

.github/workflows/tag.yaml Outdated Show resolved Hide resolved
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani
Copy link
Contributor Author

@maxsmythe do you have any additional questions/concerns?

@maxsmythe
Copy link
Contributor

One last thought: are there more specific tests than "contains"? Seems like "startswith" or similar would be good for the PR title, and an exact match for the label.

@maxsmythe
Copy link
Contributor

Though maybe the label check is doing an exact match?

@JaydipGabani
Copy link
Contributor Author

Though maybe the label check is doing an exact match?

Yip, it is matching release-pr against all labels

@JaydipGabani
Copy link
Contributor Author

One last thought: are there more specific tests than "contains"? Seems like "startswith" or similar would be good for the PR title, and an exact match for the label.

@maxsmythe updated to use startsWith from contains

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

@JaydipGabani JaydipGabani merged commit 792bbe4 into open-policy-agent:master Dec 1, 2023
16 checks passed
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tags through GH when release PR is merged
5 participants