-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: auto tagging after release pr is merged #3135
Conversation
Signed-off-by: Jaydip Gabani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
- Coverage 53.81% 53.72% -0.10%
==========================================
Files 136 136
Lines 12198 12198
==========================================
- Hits 6564 6553 -11
- Misses 5134 5142 +8
- Partials 500 503 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6faeb2b
to
3c80c0b
Compare
Signed-off-by: Jaydip Gabani <[email protected]>
@maxsmythe Found a way to gate logic without comparing commit message. PTAL |
Nice! Who has permissions to create PR labels? |
@maxsmythe anyone with write access to gatekeeper repo can edit labels and anyone with triage access can apply labels. |
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jaydip Gabani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maxsmythe do you have any additional questions/concerns? |
One last thought: are there more specific tests than "contains"? Seems like "startswith" or similar would be good for the PR title, and an exact match for the label. |
Though maybe the label check is doing an exact match? |
Yip, it is matching |
Signed-off-by: Jaydip Gabani <[email protected]>
@maxsmythe updated to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this!
Signed-off-by: Jaydip Gabani <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
What this PR does / why we need it: Eliminate the need for manually pushing tag to kick off release
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3037
Special notes for your reviewer:
Here is the workflow running on test fork
Here is the tag created as a result of the workflow