chore: fix golanglint, checkout prior to setup-go #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3206 +/- ##
==========================================
+ Coverage 53.70% 53.71% +0.01%
==========================================
Files 136 136
Lines 12198 12195 -3
==========================================
Hits 6551 6551
+ Misses 5143 5140 -3
Partials 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apeabody
changed the title
This was referenced Jan 2, 2024
apeabody
force-pushed
the
apeabody-patch-2
branch
from
31330af
to
cd947ad
Compare
|
LGTM, though it looks like lint is unhappy? |
Yeah - Needed to bump the |
apeabody
force-pushed
the
apeabody-patch-2
branch
from
cd947ad
to
9a8c645
Compare
Signed-off-by: Andrew Peabody <[email protected]>
apeabody
force-pushed
the
apeabody-patch-2
branch
from
9a8c645
to
27fee00
Compare
apeabody
commented
Jan 3, 2024
| @@ -21,10 +21,9 @@ func dashExtractor(val string) []string { | |||
| b.WriteRune(chr) | |||
| prevDash = false | |||
| continue | |||
| } else { | |||
There was a problem hiding this comment.
@maxsmythe - Would appreciate an extra set of eyes on this particular change.
ritazh
reviewed
Jan 3, 2024
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
…3206) Signed-off-by: Andrew Peabody <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
go.sumis found and cache works as expectedgolanglint-civ1.54 added support for GO 1.21golanglint-civ1.54ErrOldObjectIsNiltest to anerrorspecific test