Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating pubsub system #3646

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JaydipGabani
Copy link
Contributor

@JaydipGabani JaydipGabani commented Oct 15, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1037

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 53.16456% with 74 lines in your changes missing coverage. Please review.

Project coverage is 47.39%. Comparing base (3350319) to head (d8f3524).
Report is 171 commits behind head on master.

Files with missing lines Patch % Lines
pkg/export/dapr/fake_dapr_client.go 24.13% 22 Missing ⚠️
pkg/export/dapr/dapr.go 65.95% 14 Missing and 2 partials ⚠️
pkg/export/testdriver/testdriver.go 36.84% 11 Missing and 1 partial ⚠️
pkg/controller/export/export_config_controller.go 9.09% 10 Missing ⚠️
pkg/export/system.go 79.54% 6 Missing and 3 partials ⚠️
pkg/audit/manager.go 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (d8f3524). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (d8f3524)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3646      +/-   ##
==========================================
- Coverage   54.49%   47.39%   -7.10%     
==========================================
  Files         134      227      +93     
  Lines       12329    19089    +6760     
==========================================
+ Hits         6719     9048    +2329     
- Misses       5116     9192    +4076     
- Partials      494      849     +355     
Flag Coverage Δ
unittests 47.39% <53.16%> (-7.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaydipGabani JaydipGabani changed the title [WIP] chore: updating violation system [WIP] chore: updating pubsub system Oct 21, 2024
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
@JaydipGabani JaydipGabani changed the title [WIP] chore: updating pubsub system chore: updating pubsub system Oct 23, 2024
@JaydipGabani JaydipGabani marked this pull request as ready for review October 23, 2024 01:31
@JaydipGabani JaydipGabani requested a review from a team as a code owner October 23, 2024 01:31
@JaydipGabani
Copy link
Contributor Author

Still working on doc changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decision log exporter side car
2 participants