Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused go-version file #3711

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Nov 22, 2024

What this PR does / why we need it:

this seems to be causing confusion and it is not being used

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@sozercan sozercan requested a review from a team as a code owner November 22, 2024 03:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (3350319) to head (12e4971).
Report is 205 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (12e4971). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (12e4971)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
- Coverage   54.49%   47.56%   -6.94%     
==========================================
  Files         134      236     +102     
  Lines       12329    19909    +7580     
==========================================
+ Hits         6719     9469    +2750     
- Misses       5116     9549    +4433     
- Partials      494      891     +397     
Flag Coverage Δ
unittests 47.56% <ø> (-6.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ritazh
Copy link
Member

ritazh commented Nov 22, 2024

Looks like some tools or CI/CD might be using it. Maybe we should try to keep it up to date whenever we update Dockerfile instead of deleting it? WDYT?

@sozercan
Copy link
Member Author

sozercan commented Nov 22, 2024

imo this is dead code that we should remove since it leads to misunderstandings, and there's no way to keep it up to date since dependabot doesn't support it (since it's not a real convention). it's 100% not used by anything within GK build, and go has support for things like toolchain to support switching go versions.

@sozercan sozercan merged commit c3448d4 into open-policy-agent:master Nov 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants