-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Noise to Slotcar Plugin #118
base: main
Are you sure you want to change the base?
Conversation
This should help simulate real world scenarios where robots might report noisy location. To use publish a gz.sim.SensorNoise message to `/slotcar/translation_noise`. Note: This feature only works on GZ-SIM Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
@@ -27,6 +27,8 @@ find_package(rmf_fleet_msgs REQUIRED) | |||
find_package(rmf_building_map_msgs REQUIRED) | |||
find_package(rmf_robot_sim_common REQUIRED) | |||
|
|||
find_package(ignition-cmake2 REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Idea why I need this here but oh-well. I guess I can move the sdf code into the header and then not need it?
Going forward my preference would be to just stick to |
Makes sense. For immediate term though I need to update slotcar common cause most of the logic is there. |
I had a typed review but it's gone :| From the top of my head:
The rest looks alright (if I can test it!), there are many ways to approach this (parameter in SDF or set through a service, service that sets for all the models vs one per robot) but they all have their pros and cons and don't really have feelings strong enough to advocate for a different way to do it. |
New feature implementation
Implemented feature
This should help simulate real world scenarios where robots might report noisy location.
To use publish a gz.sim.SensorNoise message to
/slotcar/translation_noise
.Note: This feature only works on GZ-SIM