[feat]tools-v2: add bs recover volume #2918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
CrystalAnalyst
force-pushed
the
add-bs-recover-volume
branch
from
01f9ac1
to
b7587a6
Compare
baytan0720
changed the title
baytan0720
reviewed
Nov 22, 2023
There was a problem hiding this comment.
This command is a middle command. You can add sub command in middle command. You can refer to tools-v2/pkg/cli/command/curvebs/update/update.go.
| "github.com/opencurve/curve/tools-v2/proto/proto/nameserver2" | ||
| ) | ||
|
|
||
| type RecoverCertainFileRpc struct { |
baytan0720
reviewed
Nov 22, 2023
| config.AddRpcRetryTimesFlag(recoverCommand.Cmd) | ||
| config.AddBsMdsFlagOption(recoverCommand.Cmd) | ||
| config.AddBsPathRequiredFlag(recoverCommand.Cmd) | ||
| config.AddBsUserOptionFlag(recoverCommand.Cmd) |
| config.AddBsMdsFlagOption(recoverCommand.Cmd) | ||
| config.AddBsPathRequiredFlag(recoverCommand.Cmd) | ||
| config.AddBsUserOptionFlag(recoverCommand.Cmd) | ||
| config.AddBsPasswordOptionFlag(recoverCommand.Cmd) |
|
okay, thanks a lot for your advice, I'll fix it in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2588
Problem Summary: Add a feature that can recover the specified volume from the RecycleBin.
What is changed and how it works?
What's Changed: add recover directory, and inside of it is a volume sub-directory, and two files: recover.go, file.go.
How it Works: recover.go act as an entry, while file.go call the Rpc function to execute the actual recover action.
Side effects(Breaking backward compatibility? Performance regression?):
Check List