-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log viewer to watch app #849
Conversation
Signed-off-by: Tim Bert <[email protected]>
So i have been also wanting to get a log viewer for the main app as well, it would probably save us a huge amount of troubleshooting time. Is there anything to share here or is this mainly just a specific watch UI change? For our main app, would we need to switch to use OSLog throughout the app to enable this? |
let logStore = try! OSLogStore(scope: .currentProcessIdentifier) | ||
self.logs = try! logStore.getEntries().compactMap { entry in | ||
guard let logEntry = entry as? OSLogEntryLog, | ||
logEntry.subsystem.starts(with: "com.donnywals") == true else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this is checking for com.donnywals
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file in folder Rows should not have been part of the commit
Signed-off-by: Tim Bert <[email protected]>
This was just a quick hack to tackle the watch app problem. Ideally it should be shared with iOS app. Also, we should have an option to download the logs for posting of issues here. I don't think we need to switch to the new interface of OSLog. It should be just a more convenient API. But, I haven't tested yet. |
How shall we proceed? Pushing this out immediately to support testing of watch app or harmonizing approach on watchOS and iOS app? |
No description provided.