[fix] Fixed usage metric collection consent import in tasks/main.yml #452 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. if openwisp2_usage_metric_collection_consent would not pass because this var is null by default, which is falsy 2. the celery beat task was executed only if openwisp2_radius is true, which is surely unintended. I did not spot this because of indentation, let's indent the Jinja directives in this file.
This reverts commit 1f96fdd.
pandafy
force-pushed
the
fix-data-collection-consent
branch
from
c9a79bf
to
ad87dfb
Compare
pandafy
force-pushed
the
fix-data-collection-consent
branch
from
ad87dfb
to
89b3b8f
Compare
nemesifier
force-pushed
the
fix-data-collection-consent
branch
from
b12fb44
to
4395cef
Compare
nemesifier
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #452