getMediaCount does not fail if M/Counter is missing.
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `M/Counter` is not mandatory. - zimcheck doesn't check for it. - we already accept a missing `M/Counter` in `getArticleCount`. No reason to fail in `getMediaCount` if `M/Counter` is missing. We test it by reading an empty zim file. This reveal a bug in `getNamespaceBeginOffset` when there is no dirent in the direntAccessor.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
+ Coverage 57.53% 57.57% +0.04%
==========================================
Files 98 98
Lines 4540 4545 +5
Branches 1907 1911 +4
==========================================
+ Hits 2612 2617 +5
+ Misses 674 668 -6
- Partials 1254 1260 +6
☔ View full report in Codecov by Sentry. |
veloman-yunkan
approved these changes
Oct 17, 2023
kelson42
changed the title
getMediaCount do not fail if M/Counter is missing.getMediaCount does not fail if M/Counter is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M/Counteris not mandatory.M/CounteringetArticleCount.No reason to fail in
getMediaCountifM/Counteris missing.We test it by reading an empty zim file.
This reveal a bug in
getNamespaceBeginOffsetwhen there is no dirent in the direntAccessor.Fix kiwix/kiwix-tools#640