Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing omitempty for send_after field #137

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Removing omitempty for send_after field #137

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a818b8
Removed validation for send_after to make it 0 by default
koushik-swaminathan Aug 1, 2023
c69324e
Validate SendAfter to be true always
koushik-swaminathan Aug 1, 2023
ab023df
Removes send after validation
koushik-swaminathan Aug 3, 2023
0dce97e
Removed omitempty from the SendAfter datatype
koushik-swaminathan Aug 3, 2023
fa4df0f
Indendation fix
koushik-swaminathan Aug 3, 2023
4a03c4f
Merge branch 'master' into add-support-for-immediate-notification
koushik-swaminathan Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notification/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ func validateStep(step *og.Step, actionType ActionType) error {
if step.Contact.MethodOfContact == "" {
return errors.New("Method cannot be empty.")
}
if (actionType == CreateAlert || actionType == AssignedAlert) && step.SendAfter == nil {
if (actionType == CreateAlert || actionType == AssignedAlert) && step.SendAfter == nil && false {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this false wouldn't this condition be always false ?

return errors.New("SendAfter cannot be empty.")
}

Expand Down