✨ implement ListIssues and GetCreatedAt for Azure DevOps
#4419
+600
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamie Magee <[email protected]>
JamieMagee
requested review from
spencerschrock and
raghavkaul
and removed request for
a team
JamieMagee
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
With these changes the Details |
Comment on lines
+114
to
+116
| // If there are fewer commits than requested, the first commit is the createdAt date | ||
| if len(*commits) < handler.commitDepth { | ||
| handler.firstCommitCreatedAt = (*commits)[len(*commits)-1].Committer.Date.Time |
There was a problem hiding this comment.
can azure have a repository with no commits? These edge cases have been issues for Scorecard on other forges and would cause a panic
Comment on lines
+60
to
+75
| // Check if Git.CreateRepo event exists for the repository | ||
| for i := range *auditLog.DecoratedAuditLogEntries { | ||
| entry := &(*auditLog.DecoratedAuditLogEntries)[i] | ||
| if *entry.ActionId == "Git.CreateRepo" && | ||
| *entry.ProjectName == a.repourl.project && | ||
| (*entry.Data)["RepoName"] == a.repourl.name { | ||
| a.createdAt = entry.Timestamp.Time | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if *auditLog.HasMore { | ||
| continuationToken = *auditLog.ContinuationToken | ||
| } else { | ||
| break | ||
| } |
There was a problem hiding this comment.
these breaks could be returns I think. At least the first one, otherwise it will only break out of the inner loop and keep searching the audit log (if there's more)
Comment on lines
+74
to
+79
| // Fetch URI, CreatedAt, Author, and Issue comments | ||
| wiql := ` | ||
| SELECT [System.Id] | ||
| FROM WorkItems | ||
| WHERE [System.TeamProject] = @project | ||
| ORDER BY [System.Id] DESC |
There was a problem hiding this comment.
is it possible to grab the things we need from this query? or are those details only accessible via GetWorkItems?
Comment on lines
+129
to
+132
| issue := clients.Issue{ | ||
| URI: wi.Url, | ||
| CreatedAt: &parsedTime, | ||
| Author: &clients.User{Login: createdBy["uniqueName"].(string)}, |
There was a problem hiding this comment.
you check all your other type assertions, did you mean to here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
ListIssuesandGetCreatedAtthrow an unsupported errorWhat is the new behavior (if this is a feature change)?**
ListIssuesandGetCreatedAthave implementationsWhich issue(s) this PR fixes
Next step of #4177
Special notes for your reviewer
Azure DevOps doesn't have an official API to retrieve user permissions for a project or a repository. As a stopgap solution, I've defaulted all issue and comment authors to
RepoAssociationMember. This is probably a good minimum bar.The audit log is the best way to retrieve the repository creation date, but this may not be enabled. So I am using the first repository commit as a fallback value.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)