Update check.mdx to include # pants: no-infer-dep #21685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwbarnett
changed the title
huonw
added
the
release-notes:not-required
huonw
reviewed
Nov 25, 2024
| @@ -244,7 +244,7 @@ from mypy_boto3_ec2 import EC2Client | |||
|
|
|||
| if TYPE_CHECKING: | |||
| # Safe, but will be flagged as a warning | |||
There was a problem hiding this comment.
Thanks for taking the time to contribute. I think this code is already intended to be written along the lines of "you might need to add the pragma... or maybe use the better solution of having them as normal deps".
So, given that I think if we're making this change, we'll need to rewrite this comment, and also the text below:
Alternatively, you can set
# pants: no-infer-depon the lines of type-stub imports "guarded" by a check ofif TYPE_CHECKING.
An alternative to adding pants: no-infer-dep here would be leaving it as, but rephrasing the rest of the text if there's a way to make it clearer to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this example may be missing the
# pants: no-infer-dep