Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix: Creating ZIP archives with no file extension #21694

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lowvoltage
Copy link
Contributor

This fixes #21693

There are a number of changes involved:

  • Add a --adjust-sfx command-line flag when invoking the zip binary -- the actual fix for the bug
  • Modify the test_create_zip_archive unit test:
    • Parametrize it for multiple test scenarios
    • Modify the last section, as it was failing for anything but .zip extensions
    • Note: This is a best-effort change that I'm not super confident in. There may be better or more canonical ways to do this
  • Remove the unsed ZipBinary.create_archive_argv method

@lowvoltage
Copy link
Contributor Author

P.S. Any advice on the failing "Ensure PR has release notes (pull_request)" check?

Error: Please do one of:

- add release notes to the appropriate file in `docs/notes`

- label this PR with `release-notes:not-required` if it does not need them (for
  instance, if this is fixing a minor typo in documentation)

- label this PR with `category:internal` if it's an internal change

@lowvoltage lowvoltage marked this pull request as ready for review November 26, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

archive target is unable to produce a ZIP file with no extension
1 participant