[2.9.x] Update flyway-core to 9.22.1

[scala-steward]

About this PR

📦 Updates org.flywaydb:flyway-core from 8.5.13 to 9.21.2 ⚠

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.flywaydb", artifactId = "flyway-core" }
}]

^{labels: test-library-update, early-semver-major, semver-spec-major, commit-count:1}

[scala-steward]

Superseded by #401.

[ihostage]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[mkurz]

OK... wow... this is bad bad bad (bad!):
Currently, we have a failed test in the play isolated slick example: https://github.com/playframework/play-samples/actions/runs/8875574757/job/24365311327#step:11:142, but look, the test suite is reported as successful (green!) 💥 :

 [info] controller.FunctionalSpec *** ABORTED ***
[info]   com.fasterxml.jackson.databind.JsonMappingException: Scala module 2.14.3 requires Jackson Databind version >= 2.14.0 and < 2.15.0 - Found jackson-databind version 2.15.2
[info]   at com.fasterxml.jackson.module.scala.JacksonModule.setupModule(JacksonModule.scala:61)
[info]   at com.fasterxml.jackson.module.scala.JacksonModule.setupModule$(JacksonModule.scala:46)
[info]   at com.fasterxml.jackson.module.scala.DefaultScalaModule.setupModule(DefaultScalaModule.scala:17)
[info]   at com.fasterxml.jackson.databind.ObjectMapper.registerModule(ObjectMapper.java:879)
[info]   at akka.serialization.jackson.JacksonObjectMapperProvider$.$anonfun$configureObjectMapperModules$4(JacksonObjectMapperProvider.scala:242)
[info]   at akka.serialization.jackson.JacksonObjectMapperProvider$.$anonfun$configureObjectMapperModules$4$adapted(JacksonObjectMapperProvider.scala:241)
[info]   at scala.collection.immutable.List.foreach(List.scala:334)
[info]   at akka.serialization.jackson.JacksonObjectMapperProvider$.configureObjectMapperModules(JacksonObjectMapperProvider.scala:241)
[info]   at akka.serialization.jackson.JacksonObjectMapperProvider$.createObjectMapper(JacksonObjectMapperProvider.scala:265)
[info]   at akka.serialization.jackson.JacksonObjectMapperProvider.create(JacksonObjectMapperProvider.scala:359)
[info]   ...
[info] Run completed in 2 seconds, 666 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 1
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] *** 1 SUITE ABORTED ***
[error] Error during tests:
[error] 	controller.FunctionalSpec
[error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 13 s, completed Apr 29, 2024, 8:30:04 AM

This failed test even made it into the stable 2.9.x and 3.0.x branches... However, CI shows the test as green / successful, this is because the ./test.sh script calls the ./play-scala-isolated-slick-example/scripts/test-sbt script. Now when the test-sbt script fails with exit code != 0, the test.sh script does not care but just continues executing and reports back everything was ok...
To avoid this we need to set set -e in the bash script, see https://buildkite.com/docs/pipelines/writing-build-scripts#configuring-bash
For some reason, locally the test.sh fails with exit code != 0, but in the GitHub actions vm it succeeds, probably my local bash config is different, but I will not dig into that now.

[mkurz]

Funny thing is we already set the flags in the existing test scripts 😉

play-samples/play-java-rest-api-example/scripts/test-sbt

Lines 3 to 4 in 1ae950f

	set -e
	set -o pipefail

[mkurz]

Regarding flyway you might be interested in

• Proposing to move this repo to the SBT org sbt/flyway-sbt#93
• Proposing to move this repo to the playframework org flyway-play#390

[mkurz]

We can finally upgrade:

• [3.0.x] Upgrade flyway-sbt + flyway-core to 10.21.0 #779

btw.

• Proposing to move this repo to the playframework org flyway-play#390
  is being worked on, I am in contact with redgate, they should transfer the repo soon.