Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test.sh script fail when any command fails #613

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Make test.sh script fail when any command fails #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95a1737
Make test script fail when any command fails
mkurz Apr 29, 2024
eca2f02
Can't test grpc examples with Java 21+ currently
mkurz Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ jobs:
needs: changes
if: ${{ (github.event_name != 'pull_request' && !failure() && !cancelled()) || contains(fromJSON(needs.changes.outputs.samples), 'java-grpc')}}
with:
java: 17, 21
# Can't test with Java 21+ currently because of https://github.com/lightbend/ssl-config/issues/367
java: 17
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/playframework/play-samples/pull/614/files#r1582905653

scala: 2.13.x, 3.x
gradle-build-root: play-java-grpc-example
add-dimensions: >-
Expand Down Expand Up @@ -362,7 +363,8 @@ jobs:
needs: changes
if: ${{ (github.event_name != 'pull_request' && !failure() && !cancelled()) || contains(fromJSON(needs.changes.outputs.samples), 'scala-grpc')}}
with:
java: 17, 21
# Can't test with Java 21+ currently because of https://github.com/lightbend/ssl-config/issues/367
java: 17
scala: 2.13.x, 3.x
gradle-build-root: play-scala-grpc-example
add-dimensions: >-
Expand Down
7 changes: 7 additions & 0 deletions test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
#!/usr/bin/env bash

# -e Exit script immediately if any command returns a non-zero exit status.
# -u Exit script immediately if an undefined variable is used.
# -o pipefail Ensure Bash pipelines return a non-zero status if any of the commands fail,
# rather than returning the exit status of the last command in the pipeline.
set -euo pipefail

if [ -z "$MATRIX_SCALA" ]; then
echo "Error: the environment variable MATRIX_SCALA is not set"
exit 1
Expand Down