-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service] refactor: TargetNumRelays
var usage to param usage
#943
base: todo_beta/params/target_num_relays
Are you sure you want to change the base?
[Service] refactor: TargetNumRelays
var usage to param usage
#943
Conversation
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 943) |
ctx, | ||
logger, | ||
serviceId, | ||
numRelays, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need to make this change:
https://discord.com/channels/824324475256438814/1138895490331705354/1307077093351362621
numRelays, | |
targetNumRelays, |
(cc @red-0ne )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change causes some test failures:
=== RUN TestComputeNewDifficultyHash_MonotonicallyIncreasingRelays
update_relay_mining_difficulty_test.go:45: Relay Mining Increasing Difficult Debug. NumRelays: 1000, EMA: 90099, TargetHash: ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
update_relay_mining_difficulty_test.go:34:
Error Trace: /home/bwhite/Projects/pokt/poktroll/x/service/keeper/update_relay_mining_difficulty_test.go:34
Error: "10000" is not greater than "90099"
Test: TestComputeNewDifficultyHash_MonotonicallyIncreasingRelays
--- FAIL: TestComputeNewDifficultyHash_MonotonicallyIncreasingRelays (0.00s)
=== RUN TestUpdateRelayMiningDifficulty_Base
update_relay_mining_difficulty_test.go:105:
Error Trace: /home/bwhite/Projects/pokt/poktroll/x/service/keeper/update_relay_mining_difficulty_test.go:105
Error: Not equal:
expected: 0x3e8
actual : 0x15ff3
Test: TestUpdateRelayMiningDifficulty_Base
--- FAIL: TestUpdateRelayMiningDifficulty_Base (0.00s)
Expected :0x3e8
Actual :0x15ff3
=== RUN TestUpdateRelayMiningDifficulty_FirstDifficulty/First_Difficulty_way_below_target
update_relay_mining_difficulty_test.go:217:
Error Trace: /home/bwhite/Projects/pokt/poktroll/x/service/keeper/update_relay_mining_difficulty_test.go:217
Error: Not equal:
expected: 0x64
actual : 0x15f99
Test: TestUpdateRelayMiningDifficulty_FirstDifficulty/First_Difficulty_way_below_target
--- FAIL: TestUpdateRelayMiningDifficulty_FirstDifficulty/First_Difficulty_way_below_target (0.00s)
Expected :0x64
Actual :0x15f99
=== RUN TestUpdateRelayMiningDifficulty_FirstDifficulty/First_Difficulty_way_above_target
update_relay_mining_difficulty_test.go:217:
Error Trace: /home/bwhite/Projects/pokt/poktroll/x/service/keeper/update_relay_mining_difficulty_test.go:217
Error: Not equal:
expected: 0x5f5e100
actual : 0x99f610
Test: TestUpdateRelayMiningDifficulty_FirstDifficulty/First_Difficulty_way_above_target
--- FAIL: TestUpdateRelayMiningDifficulty_FirstDifficulty/First_Difficulty_way_above_target (0.00s)
Expected :0x5f5e100
Actual :0x99f610
Summary
Replace usage of
servicekeeper.TargetNumRelays
with the new param and delete it.Issue
TODO_BETA
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist