-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code Health] fix: gateway module gRPC status error returns #955
Open
bryanchriswhite
wants to merge
4
commits into
main
Choose a base branch
from
issues/860/errors/gateway
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
gateway
Changes related to the Gateway actor
on-chain
On-chain business logic
code health
Cleans up some code
devnet-test-e2e
consensus-breaking
IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade.
labels
Nov 22, 2024
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 955) |
github-actions
bot
added
devnet
push-image
CI related - pushes images to ghcr.io
labels
Nov 22, 2024
bryanchriswhite
commented
Nov 25, 2024
bryanchriswhite
commented
Nov 25, 2024
bryanchriswhite
commented
Nov 25, 2024
bryanchriswhite
commented
Nov 25, 2024
bryanchriswhite
commented
Nov 25, 2024
bryanchriswhite
requested review from
red-0ne
and removed request for
red-0ne
November 25, 2024 14:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code health
Cleans up some code
consensus-breaking
IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade.
devnet
devnet-test-e2e
gateway
Changes related to the Gateway actor
on-chain
On-chain business logic
push-image
CI related - pushes images to ghcr.io
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure all gateway message and query handlers return gRPC status errors.
Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist