-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common Table component (part 1) #2376
Open
lindapaiste
wants to merge
9
commits into
processing:develop
Choose a base branch
from
lindapaiste:refactor/table-base
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,036
−1,182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
4 tasks
# Conflicts: # client/modules/User/components/Collection.jsx # client/styles/components/_sketch-list.scss
# Conflicts: # client/modules/IDE/components/CollectionList/CollectionList.jsx # client/modules/IDE/selectors/collections.js # client/modules/IDE/selectors/projects.js # client/modules/User/components/Collection.jsx
Not quite as 🧹 as before but I fixed the conflicts by putting the sorting state back into Redux. |
# Conflicts: # client/modules/IDE/components/AssetList.jsx # client/modules/IDE/components/CollectionList/CollectionListRow.jsx # client/modules/IDE/components/SketchList.jsx # client/modules/IDE/components/__snapshots__/SketchList.unit.test.jsx.snap # client/styles/components/_sketch-list.scss
After all the merges there is something a bit wonky about the sorting, where sometimes clicking on the table header flips the sorting twice. This is reflected in the failing test. I'm investigating. |
4 tasks
This was referenced Mar 27, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442
Fixes #2375
Progress on #2358
This is part 1 because I have cleaned up the __Table components, but not the __TableRow components.
Code cleanup:
TableBase
component to handle common logic of tables:<Loader/>
when loading.TableBase
andTableHeaderCell
.TableBase
in existing components:AssetList
- converted to function componentCollectionList
- converted to function componentSketchList
- converted to function componentCollection
- still a class component because I have other open PRs that touch this (MoveCollectionMetadata
into its own component. #2253)TableBase
, so removesorting
from Redux.sorting
reducer, actions, and selectors.SketchList
which checked redux actions.sketches-table
on all tables (can add additional classes alongside it), and delete SCSS properties onasset-table
which are duplicates.styled-components
:Bug Fixes:
Collection
component can be sorted (Sketches table on collection page is not sortable #2375)SketchList
column header "Sketch" now shows the correctaria-label
. It was "Sort by Sketch descending." but should be "ascending".New Features:
AssetList
can be sorted.aria-sort
andaria-pressed
to column headers.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123