Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pronto-fasterer.gemspec #17

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Update pronto-fasterer.gemspec #17

merged 2 commits into from
Sep 23, 2024

Conversation

KieranP
Copy link
Contributor

@KieranP KieranP commented Aug 7, 2024 •
edited
Loading

Fixed #16

cc @ashkulz

@KieranP KieranP requested a review from a team as a code owner August 7, 2024 10:11
@ashkulz
Copy link
Member

ashkulz commented Aug 7, 2024

@KieranP have you tested that it works properly?

@campbecf
Copy link
Contributor

@ashkulz @KieranP We may want to consider something like

s.add_runtime_dependency('fasterer', '>= 0.11', '< 1.0')

Since we've had to have a PR for each minor version bump.

See:
#9
#12
#14

I'm testing this on a fork I've made.

@campbecf
Copy link
Contributor

No issues using fasterer 0.11 so far. Specs pass as well.

@KieranP
Copy link
Contributor Author

KieranP commented Sep 20, 2024 •
edited
Loading

@campbecf Thanks for the suggestion. Have changed to ('fasterer', '>= 0.10', '< 1.0')

@ashkulz ashkulz merged commit e832a77 into prontolabs:master Sep 23, 2024
9 checks passed
@hlascelles hlascelles mentioned this pull request Oct 11, 2024
Closed
@hlascelles
Copy link

Can we get a new gem cut please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fasterer semantic version is too strict
4 participants
@KieranP @ashkulz @campbecf @hlascelles