Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated index.html #572

Closed
wants to merge 1 commit into from
Closed

Updated index.html #572

wants to merge 1 commit into from

Conversation

YorhaBlue
Copy link
Contributor

Fixes #568 Update broken links in index.html page

Line 157: changed "https://github.com/publiclab/plots2/blob/master/README.md" to "https://github.com/publiclab/plots2/blob/main/README.md"
Line 161: changed "https://github.com/publiclab/plots2/issues/new" to "https://github.com/publiclab/plots2/issues/new/choose"
Line 215: added href "https://publiclab.org/notes/warren/10-31-2016/create-a-welcoming-first-timers-only-issue-to-invite-new-software-contributors"

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented May 11, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@on2onyekachi
Copy link
Contributor

Great work! @YorhaBlue I see you made a separate PR for each file.

@YorhaBlue
Copy link
Contributor Author

Thanks @on2onyekachi. But yes, sorry about the separate PRs -- still getting used to GitHub! I'll make sure to consolidate everything next time I work on an issue.

@on2onyekachi
Copy link
Contributor

Okay, @YorhaBlue,

@TildaDares or other mentors will get to review this and merge it.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YorhaBlue, as @on2onyekachi said it'll be better if all of the changes related to this issue are in one PR. Thanks!!

@YorhaBlue
Copy link
Contributor Author

Closing since I created PR #577 with the collective changes

@YorhaBlue YorhaBlue closed this May 13, 2022
@YorhaBlue YorhaBlue deleted the patch-1 branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update broken links in index.html page
3 participants