fix: upgrade dependencies for angular v18 compatibility #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the support its much appreciated. We usually don't commit the migrations.json file in this repo. The bumps are inferred from the git commit history so there is not need to update the project version directly- |
|
Ah I really should have caught that, sorry! Happy to help :) I updated the PR to remove the inclusion of that file, along with some further peer dependency fixes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to the project that were performed after running
nx migrate latestwhich brought all of the Angular dependencies to the latest and greatest.Notably this also introduces support for those who are already using Angular 18 in their own projects, as the current version fails to install due to being capped at v17.
This does not bump the version in any way as I figured it'd be best to let the push-based team take care of that.
I tested the application by running
npm run serveand can confirm that the library and demo app work as expected.