Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the user to have a lazy configuration for the svg by allowing the url option to return an observable and reacting to the change.
These changes do not seem to break the
open-closed principle
and do not cause breaking changes.However, this does mean typing for the options a little less strict. As
SvgLoadStrategy.load
now takes a string | Observable and this is not inferred.Additionally, this is only really possible because of the new function runInInjectionContext because a real user will most likely use a service and not a simple function that returns an observable.
Closes: #77
Notes
This is a draft, still need to cleanup code