-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the tests command and deprecate access to the module. #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
force-pushed
the
feature/graceful-drop-tests
branch
2 times, most recently
from
July 29, 2024 14:20
d6dbddc
to
eadd7a6
Compare
I've had to move the DeprecationWarning to only trigger on access to |
I can confirm that this change allows previously-failing install of
|
1 task
jaraco
force-pushed
the
feature/graceful-drop-tests
branch
from
July 29, 2024 14:45
eadd7a6
to
c437aaa
Compare
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 29, 2024
In 72.0.0 the test command was finally removed as has been threatened for a while. It turns out that many people still had referenced it in their setup.py even if they didn't actually use it, so simply building a wheel then failed -- the only deprecation warning had been if you actually attempted to use `setup.py test`. Setuptools 72.1.0 adds a deprecation shim to allow those packages to still build wheels successfully, to give projects time and warning that they need to remove this last remaining trace. We drop the old version too, as we don't want users to hit the version that breaks wheel building. Bug: pypa/setuptools#4520 Bug: pypa/setuptools#4522 Signed-off-by: Eli Schwartz <[email protected]>
This was referenced Jul 29, 2024
jtrobles-cdd
added a commit
to cordada/lib-cl-sii-python
that referenced
this pull request
Aug 23, 2024
`setup.py test` has been deprecated for years. See: - pypa/setuptools#1684 - pypa/setuptools#4522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As suggested by @hauntsaninja, add a deprecation warning to access of
setuptools.command.test
and raise an error when running the command.This approach provides a gentler offboarding for projects still reliant on the presence of the module or the command. Currently, it gives 3 months for projects to cut new releases in response to the change. This deadline can be extended if deemed necessary.
Closes #4520; Closes #4519.
Pull Request Checklist
newsfragments/
.(See documentation for details)