Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1452 Testimonial card position #1458

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

Siddh744542
Copy link
Contributor

@Siddh744542 Siddh744542 commented Feb 15, 2024

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

fixed the position of the Testimonial card position

Fixes #1452

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit fbdce75
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65d0268942925f0008653ef2
😎 Deploy Preview https://deploy-preview-1458--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few issues are there
display 1920X1080

Screenshot_2024-02-16_18_41_48

@priyankarpal priyankarpal added the changes required need to change some thing label Feb 16, 2024
@Siddh744542
Copy link
Contributor Author

Thanks for the reviewing my PR @priyankarpal, will update the changes soon

@Siddh744542
Copy link
Contributor Author

@priyankarpal changes done

on larger screen :
image

on smaller screen :
image

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal changed the title fixed : #1452 Testimonial card position fix: #1452 Testimonial card position Feb 17, 2024
@priyankarpal priyankarpal added 🛠 goal: fix Bug fix and removed chore labels Feb 17, 2024
@priyankarpal priyankarpal merged commit 6f0bb26 into reactplay:main Feb 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Testimonial card position
2 participants