Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hover behavior in trending plays #1487

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

saifscripts
Copy link
Contributor

Add 'position: relative' to .play-card-container class.

Previously, hovering over the Trending Plays cards didn't activate the on-hover action until the cursor passed the middle of the box. This was due to the positioning of the .play-card-container class. This commit adds 'position: relative' to the .play-card-container class, ensuring immediate activation of the on-hover action anywhere inside the box in the Trending Plays cards.

Issue: #1480

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Add 'position: relative' to .play-card-container class.

Previously, hovering over the Trending Plays cards didn't 
activate the on-hover action until the cursor passed the 
middle of the box. This was due to the positioning of the 
.play-card-container class. This commit adds 'position: relative' 
to the .play-card-container class, ensuring immediate 
activation of the on-hover action anywhere inside the box 
in the Trending Plays cards.

Issue: reactplay#1480
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 27c4ea6
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/660ea9e6ccc3440008168c44
😎 Deploy Preview https://deploy-preview-1487--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal added the bug Something isn't working label Apr 4, 2024
@priyankarpal priyankarpal changed the title fix(common): fix hover behavior in trending plays fix: hover behavior in trending plays Apr 4, 2024
@priyankarpal priyankarpal added 🛠 goal: fix Bug fix and removed bug Something isn't working labels Apr 4, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 80144b3 into reactplay:main Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants