Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(releases): blocking UI elements that allow for adding documents to inactive releases #7879

Draft
wants to merge 2 commits into
base: corel
Choose a base branch
from

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Nov 25, 2024

Description

blockAddDocsToScheduled

What to review

Testing

Notes for release

N/A

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ❌ Failed (Inspect) Nov 26, 2024 4:49pm
performance-studio ❌ Failed (Inspect) 💬 Add feedback Nov 26, 2024 4:49pm
test-next-studio ❌ Failed (Inspect) Nov 26, 2024 4:49pm
test-studio ❌ Failed (Inspect) Nov 26, 2024 4:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 4:49pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Nov 25, 2024 8:59 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 39s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 43s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 52s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 25 Nov 2024 21:02:46 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.0 efps (63ms) 11.5 efps (87ms) +25ms (+39.2%) 🔴
article (body) 53.5 efps (19ms) 49.5 efps (20ms) +2ms (+8.0%)
article (string inside object) 17.2 efps (58ms) 12.4 efps (81ms) +23ms (+38.8%) 🔴
article (string inside array) 15.4 efps (65ms) 10.5 efps (95ms) +30ms (+46.2%) 🔴
recipe (name) 30.8 efps (33ms) 20.4 efps (49ms) +17ms (+50.8%) 🔴
recipe (description) 35.1 efps (29ms) 21.7 efps (46ms) +18ms (+61.4%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.3 efps (70ms) 6.0 efps (168ms) +98ms (+140.0%) 🔴
synthetic (string inside object) 14.9 efps (67ms) 6.1 efps (164ms) +97ms (+144.8%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 63ms 67ms 76ms 238ms 546ms 14.0s
article (body) 19ms 21ms 26ms 224ms 338ms 6.1s
article (string inside object) 58ms 62ms 81ms 372ms 590ms 9.1s
article (string inside array) 65ms 71ms 77ms 249ms 591ms 9.5s
recipe (name) 33ms 34ms 40ms 66ms 0ms 8.5s
recipe (description) 29ms 30ms 32ms 34ms 0ms 5.7s
recipe (instructions) 6ms 8ms 9ms 12ms 0ms 3.3s
synthetic (title) 70ms 74ms 82ms 378ms 1556ms 15.4s
synthetic (string inside object) 67ms 70ms 77ms 313ms 1400ms 10.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 87ms 93ms 124ms 360ms 3195ms 17.1s
article (body) 20ms 31ms 58ms 173ms 653ms 7.4s
article (string inside object) 81ms 85ms 95ms 260ms 2808ms 11.8s
article (string inside array) 95ms 103ms 166ms 370ms 3508ms 13.1s
recipe (name) 49ms 52ms 73ms 114ms 849ms 10.8s
recipe (description) 46ms 47ms 56ms 104ms 690ms 7.8s
recipe (instructions) 6ms 8ms 9ms 36ms 0ms 3.3s
synthetic (title) 168ms 186ms 248ms 755ms 9814ms 27.8s
synthetic (string inside object) 164ms 175ms 181ms 1066ms 9470ms 20.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant